feat(updates): update modal, auto-download setting, changelog by charlesvien · Pull Request #2818 · PostHog/code

charlesvien · 2026-06-21T02:17:36Z

Problem

The move to electron-updater gave us a new set of primitives that were previously unavailable to us: checking for an update without downloading it, byte-level download progress, an explicit download trigger, install-on-quit and release notes at check time. The old experience used none of them. Updates downloaded silently, and the only UI was a bottom-left banner with a "Restart" button that appeared once the download had already finished. There was no opt-in download, no release notes, no progress and no way to browse the changelog.

Changes

Three user-facing additions, built on those primitives:

Update modal. Updates no longer auto-download by default. The bottom-left banner becomes a passive "Update available" that opens a modal showing the release notes (rendered markdown), your current version and a Download button with a live progress bar (percent and MB/s). You can close the modal while the download runs and the banner mirrors the progress; when it finishes the action becomes "Restart to update".
"Download updates automatically" setting in General (default off). When on, updates download in the background and install on the next quit, with the Restart button still available for an immediate install. The renderer pushes the preference to the core updater through a new updates.setAutoDownload procedure.
"View changelog" in the project switcher opens a "What's New" modal: a timeline of GitHub releases fetched by a new GitHubReleasesService (in workspace-server, public GET /repos/PostHog/code/releases, Zod-parsed and cached). The current version is marked, and the modal auto-shows once on the first launch after an update installs (tracked with a persisted lastSeenChangelogVersion).

Plumbing: IUpdater gains download(), onDownloadProgress() and setAutoDownload(), and onUpdateAvailable now carries the release notes. The electron-updater adapter sets autoDownload to false and autoInstallOnAppQuit to true and wires the download-progress event. UpdatesService gains an "available" state, download progress and the auto-download decision, and the status payload plus the renderer stores carry the new fields.

Auto-update stays macOS and Windows only; the What's New changelog works on every platform.

Stacked on #2817.

How did you test this?

pnpm typecheck (22 of 22), pnpm lint and pnpm build all pass.
pnpm test passes. New unit tests cover the UpdatesService transitions (available, then requestDownload, then downloading, then ready, plus the auto-download branch) with a faked IUpdater, and the GitHubReleasesService mapping, caching and error handling with a faked fetch.
Driving the live modal and banner states in the packaged app over CDP is a follow-up.

Automatic notifications

Publish to changelog?
Alert Sales and Marketing teams?

charlesvien · 2026-06-21T02:17:53Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-06-21T02:18:39Z

React Doctor found 1 issue in 1 file · 1 warning.

1 warning

src/features/sidebar/components/ProjectSwitcher.tsx

⚠️ src/features/sidebar/components/ProjectSwitcher.tsx:65 Large component is hard to read and change no-giant-component

_{Reviewed by React Doctor for commit 2edb0b3.}

greptile-apps · 2026-06-21T02:22:30Z

Comments Outside Diff (3)

packages/ui/src/features/settings/sections/GeneralSettings.tsx, line 798-810 (link)

Redundant server call when toggling auto-download

handleAutoDownloadChange calls both setDownloadUpdatesAutomatically (which triggers the module-level syncAutoDownload subscription in updates.ts) AND autoDownloadMutation.mutate. The subscription in updates.ts already forwards every settings change to the host via hostTrpcClient.updates.setAutoDownload.mutate, so each toggle sends two setAutoDownload calls to the server. Since the mutations are idempotent the result is correct, but autoDownloadMutation here is dead weight. The autoDownloadMutation declaration and its use in handleAutoDownloadChange can be removed.

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/ui/src/features/settings/sections/GeneralSettings.tsx
Line: 798-810

Comment:
**Redundant server call when toggling auto-download**

`handleAutoDownloadChange` calls both `setDownloadUpdatesAutomatically` (which triggers the module-level `syncAutoDownload` subscription in `updates.ts`) AND `autoDownloadMutation.mutate`. The subscription in `updates.ts` already forwards every settings change to the host via `hostTrpcClient.updates.setAutoDownload.mutate`, so each toggle sends two `setAutoDownload` calls to the server. Since the mutations are idempotent the result is correct, but `autoDownloadMutation` here is dead weight. The `autoDownloadMutation` declaration and its use in `handleAutoDownloadChange` can be removed.

How can I resolve this? If you propose a fix, please make it concise.

packages/ui/src/features/updates/WhatsNewModal.tsx, line 1403 (link)

"Latest" badge can land on a pre-release

GitHubReleasesService.listReleases filters out drafts but keeps pre-releases, and the GitHub API returns releases newest-first. If the most recent published release is a pre-release, index === 0 will be a pre-release entry and receive the Latest badge. Consider either filtering pre-releases out of the list, or basing the badge on !release.isPrerelease rather than position.

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/ui/src/features/updates/WhatsNewModal.tsx
Line: 1403

Comment:
**"Latest" badge can land on a pre-release**

`GitHubReleasesService.listReleases` filters out drafts but keeps pre-releases, and the GitHub API returns releases newest-first. If the most recent published release is a pre-release, `index === 0` will be a pre-release entry and receive the `Latest` badge. Consider either filtering pre-releases out of the list, or basing the badge on `!release.isPrerelease` rather than position.

How can I resolve this? If you propose a fix, please make it concise.

packages/core/src/updates/updateStore.test.ts, line 244-257 (link)

No direct unit test for the new available branch in deriveUpdateUiStatus

updateStore.test.ts now covers the downloading case, and the available path is exercised indirectly via updates.test.ts, but there is no direct unit test for deriveUpdateUiStatus({ available: true, availableVersion: "...", ... }). Prefer a parameterised test alongside the existing cases here so the mapping is documented and protected at the unit level.

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/core/src/updates/updateStore.test.ts
Line: 244-257

Comment:
**No direct unit test for the new `available` branch in `deriveUpdateUiStatus`**

`updateStore.test.ts` now covers the `downloading` case, and the `available` path is exercised indirectly via `updates.test.ts`, but there is no direct unit test for `deriveUpdateUiStatus({ available: true, availableVersion: "...", ... })`. Prefer a parameterised test alongside the existing cases here so the mapping is documented and protected at the unit level.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI

Fix the following 4 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 4
packages/ui/src/features/sidebar/components/UpdateBanner.tsx:15-17
`useUpdateView()` is called twice in the same component, creating two separate store subscriptions and violating OnceAndOnlyOnce. `isEnabled` should simply be added to the first destructure.

```suggestion
  const { status, version, availableVersion, downloadPercent, isEnabled } =
    useUpdateView();
```

### Issue 2 of 4
packages/ui/src/features/settings/sections/GeneralSettings.tsx:798-810
**Redundant server call when toggling auto-download**

`handleAutoDownloadChange` calls both `setDownloadUpdatesAutomatically` (which triggers the module-level `syncAutoDownload` subscription in `updates.ts`) AND `autoDownloadMutation.mutate`. The subscription in `updates.ts` already forwards every settings change to the host via `hostTrpcClient.updates.setAutoDownload.mutate`, so each toggle sends two `setAutoDownload` calls to the server. Since the mutations are idempotent the result is correct, but `autoDownloadMutation` here is dead weight. The `autoDownloadMutation` declaration and its use in `handleAutoDownloadChange` can be removed.

### Issue 3 of 4
packages/ui/src/features/updates/WhatsNewModal.tsx:1403
**"Latest" badge can land on a pre-release**

`GitHubReleasesService.listReleases` filters out drafts but keeps pre-releases, and the GitHub API returns releases newest-first. If the most recent published release is a pre-release, `index === 0` will be a pre-release entry and receive the `Latest` badge. Consider either filtering pre-releases out of the list, or basing the badge on `!release.isPrerelease` rather than position.

### Issue 4 of 4
packages/core/src/updates/updateStore.test.ts:244-257
**No direct unit test for the new `available` branch in `deriveUpdateUiStatus`**

`updateStore.test.ts` now covers the `downloading` case, and the `available` path is exercised indirectly via `updates.test.ts`, but there is no direct unit test for `deriveUpdateUiStatus({ available: true, availableVersion: "...", ... })`. Prefer a parameterised test alongside the existing cases here so the mapping is documented and protected at the unit level.

_{Reviews (1): Last reviewed commit: "add update modal, auto-download, changel..." | Re-trigger Greptile}

stamphog

This PR exceeds the automated review size ceiling (1402 lines, 30 files) and touches multiple areas including Electron updater behavior, platform interfaces, core store logic, and new UI modals. The scope is too large to review confidently without human oversight — request a team member review before re-requesting auto-approval.

stamphog

Gates denied this PR for exceeding size limits (1552 lines, 32 files). The change touches Electron updater behavior, platform interfaces, core store logic, host-router wiring, and multiple new UI modals — too broad to auto-approve. A prior bot review also flagged it as requiring human oversight. Request a team member review before re-requesting.

charlesvien changed the title ~~add update modal, auto-download, changelog modal~~ feat(updates): update modal, auto-download setting, changelog Jun 21, 2026

charlesvien marked this pull request as ready for review June 21, 2026 02:17

This was referenced Jun 21, 2026

refactor(code): migrate from electron forge to electron-builder #2795

Open

refactor(code): migrate build and dev to electron-vite #2811

Open

charlesvien mentioned this pull request Jun 21, 2026

chore(code): upgrade Electron 42, React 19.2, Vite 7 and deps #2817

Open

2 tasks

greptile-apps Bot reviewed Jun 21, 2026

View reviewed changes

Comment thread packages/ui/src/features/sidebar/components/UpdateBanner.tsx Outdated

charlesvien force-pushed the chore/dependency-upgrades branch from f934def to 3b3c512 Compare June 21, 2026 05:09

charlesvien force-pushed the feat/auto-update-ux branch 2 times, most recently from f47c58b to 8ebb593 Compare June 21, 2026 08:11

charlesvien force-pushed the chore/dependency-upgrades branch from 3b3c512 to 05dc196 Compare June 21, 2026 08:11

charlesvien force-pushed the feat/auto-update-ux branch from 8ebb593 to f7ef353 Compare June 21, 2026 08:53

charlesvien force-pushed the chore/dependency-upgrades branch from 05dc196 to 8456ef4 Compare June 21, 2026 08:53

charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jun 21, 2026

stamphog Bot reviewed Jun 21, 2026

View reviewed changes

stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jun 21, 2026

charlesvien force-pushed the chore/dependency-upgrades branch from 8456ef4 to 6cdb962 Compare June 22, 2026 06:01

charlesvien force-pushed the feat/auto-update-ux branch from 97fb702 to d07a09a Compare June 22, 2026 06:01

charlesvien mentioned this pull request Jun 22, 2026

test(updates): macOS auto-update E2E with real install + relaunch #2828

Open

2 tasks

charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jun 22, 2026

stamphog Bot reviewed Jun 22, 2026

View reviewed changes

stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jun 22, 2026

charlesvien force-pushed the chore/dependency-upgrades branch from 6cdb962 to ae7bae2 Compare June 22, 2026 15:32

charlesvien force-pushed the feat/auto-update-ux branch from f2656c7 to 482f3bf Compare June 22, 2026 15:32

charlesvien added 4 commits June 22, 2026 11:21

add update modal, auto-download, changelog modal

1946cfb

Update WhatsNewModal.tsx

ade5276

Update router.ts

5c81c0a

group changelog by day/week and move menu item

dd865a9

charlesvien added 10 commits June 22, 2026 11:21

add close button to changelog modal

9506604

Update WhatsNewModal.tsx

9810f0e

merge duplicate useUpdateView subscription

7282335

fix update banner re-check and auto-download sync

3085916

restore update banner button and revamp modal

46582a2

show download size and restore banner view button

24e1184

default to automatic update downloads

c59c9c1

move update settings to updates tab

34e7ebf

match update modal style to release modal

a1e408a

add release notes skeleton, restore later button

2edb0b3

charlesvien force-pushed the chore/dependency-upgrades branch from ae7bae2 to 96ed56f Compare June 22, 2026 18:25

charlesvien force-pushed the feat/auto-update-ux branch from 482f3bf to 2edb0b3 Compare June 22, 2026 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(updates): update modal, auto-download setting, changelog#2818

feat(updates): update modal, auto-download setting, changelog#2818
charlesvien wants to merge 14 commits into
chore/dependency-upgradesfrom
feat/auto-update-ux

charlesvien commented Jun 21, 2026 •

edited

Loading

Uh oh!

charlesvien commented Jun 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 21, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jun 21, 2026 •

edited

Loading

Comments Outside Diff (3)

Uh oh!

Uh oh!

stamphog Bot left a comment

Uh oh!

stamphog Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

charlesvien commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this?

Automatic notifications

Uh oh!

charlesvien commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments Outside Diff (3)

Uh oh!

Uh oh!

stamphog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

stamphog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

charlesvien commented Jun 21, 2026 •

edited

Loading

charlesvien commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading

greptile-apps Bot commented Jun 21, 2026 •

edited

Loading